summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorDan McGee <dan@archlinux.org>2011-06-28 17:46:04 -0500
committerDan McGee <dan@archlinux.org>2011-06-30 11:51:36 -0500
commitb94e8ecd1fec4426baab8c90e7fc0d5583acdbef (patch)
treef3d4d2800610893956ccad1691509ddf53c7f487 /src
parent9efd10cd2ac9a7654b2c7c94df86bf09ab54f41a (diff)
downloadpacman-b94e8ecd1fec4426baab8c90e7fc0d5583acdbef.tar.xz
Fix a few warnings pointed out via clang scan-build
Some of these are legit (the backup hash NULL checks), while others are either extemely unlikely or just impossible for the static code analysis to prove, but are worth adding anyway because they have little overhead. Signed-off-by: Dan McGee <dan@archlinux.org>
Diffstat (limited to 'src')
-rw-r--r--src/pacman/pacman.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c
index 9ed1c612..cd59c8d4 100644
--- a/src/pacman/pacman.c
+++ b/src/pacman/pacman.c
@@ -721,15 +721,18 @@ static void cl_to_log(int argc, char* argv[])
{
size_t size = 0;
int i;
- for(i = 0; i<argc; i++) {
+ for(i = 0; i < argc; i++) {
size += strlen(argv[i]) + 1;
}
+ if(!size) {
+ return;
+ }
char *cl_text = malloc(size);
if(!cl_text) {
return;
}
char *p = cl_text;
- for(i = 0; i<argc-1; i++) {
+ for(i = 0; i < argc - 1; i++) {
strcpy(p, argv[i]);
p += strlen(argv[i]);
*p++ = ' ';