From 0a9cb2b3f703b53626179700d348214f6d4b0cef Mon Sep 17 00:00:00 2001
From: Erich Eckner <git@eckner.net>
Date: Tue, 6 Nov 2018 10:25:08 +0100
Subject: buildmaster/build-list.php: needed some urlencode()s and urldecode()s

---
 buildmaster/build-list.php | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

(limited to 'buildmaster')

diff --git a/buildmaster/build-list.php b/buildmaster/build-list.php
index f915788..11ccb59 100644
--- a/buildmaster/build-list.php
+++ b/buildmaster/build-list.php
@@ -63,12 +63,11 @@ foreach ( $multi_select_search_criteria as $criterium ) {
   if (isset($_GET[$criterium["name"]])) {
     $filter .= " AND " . $criterium["query_pre"];
     foreach ($criterium["values"] as $value)
-      if (strpos("&" . $_SERVER["QUERY_STRING"] . "&", "&" . $criterium["name"] . "=" . $value . "&") !== false)
+      if (strpos("&" . $_SERVER["QUERY_STRING"] . "&", "&" . $criterium["name"] . "=" . urlencode($value) . "&") !== false)
         $filter .= $criterium["query_in_pre"] . $value . $criterium["query_in_post"];
     $filter .= $criterium["query_post"];
   }
 }
-
 $single_select_search_criteria = array(
   "broken" => array(
     "name" => "broken",
@@ -436,7 +435,7 @@ foreach ($multi_select_search_criteria as $criterium) {
   print "              <select multiple=\"multiple\" id=\"id_" . $criterium["name"] . "\" name=\"" . $criterium["name"] . "\">\n";
   foreach ($criterium["values"] as $value) {
     print "                <option value=\"" . $value . "\"";
-    if (strpos( "&" . $_SERVER["QUERY_STRING"] . "&", "&" . $criterium["name"] . "=" . $value . "&") !== false)
+    if (strpos( "&" . $_SERVER["QUERY_STRING"] . "&", "&" . $criterium["name"] . "=" . urlencode($value) . "&") !== false)
       print " selected=\"selected\"";
     print ">" . $value . "</option>\n";
   }
-- 
cgit v1.2.3