From 1086950c82ab649ffc36a00cd8d343da376252fe Mon Sep 17 00:00:00 2001 From: Dan McGee Date: Sun, 23 Mar 2008 15:28:48 -0500 Subject: memleak fix: ensure backup fname isn't lost if unused The _alpm_backup_split function always alloced memory for the fname, and we let it disappear in a specific case (upgrade026.py). Fix the issue. Signed-off-by: Dan McGee --- lib/libalpm/add.c | 1 + 1 file changed, 1 insertion(+) (limited to 'lib/libalpm/add.c') diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c index eddf637e..8b06bef5 100644 --- a/lib/libalpm/add.c +++ b/lib/libalpm/add.c @@ -243,6 +243,7 @@ static int upgrade_remove(pmpkg_t *oldpkg, pmpkg_t *newpkg, pmtrans_t *trans, pm char *backup = _alpm_backup_file(b->data); /* safety check (fix the upgrade026 pactest) */ if(!alpm_list_find_str(filelist, backup)) { + FREE(backup); continue; } _alpm_log(PM_LOG_DEBUG, "adding %s to the NoUpgrade array temporarily\n", -- cgit v1.2.3-54-g00ecf