diff options
| author | Chantry Xavier <shiningxc@gmail.com> | 2008-04-17 09:02:11 +0200 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2008-04-17 14:29:08 -0500 |
| commit | c465d9e848b19b495259c7021a583c29fba92b44 (patch) | |
| tree | 3860d73280a51a812f9625f5269f4e97b8093240 /submitting-patches | |
| parent | 5e375aa9d387b2ef703dd35f60df1daad6a40237 (diff) | |
| download | pacman-c465d9e848b19b495259c7021a583c29fba92b44.tar.xz | |
pactest : Use tarfile module.
Previously, tar was called manually with os.system. This caused one fork per
package/db creation, which is costly, especially on cygwin. Besides, it also
caused some problems with directory with whitespaces (that could also be
fixed with quotes, but well..)
Using tarfile module is cleaner and more efficient, and still easy enough.
Benchmark (time make check) :
- windows / cygwin
prepatch:
real 6m36.360s
user 2m28.914s
sys 2m35.866s
postpatch:
real 5m25.428s
user 1m26.029s
sys 2m0.006s
- linux
prepatch:
real 1m22.629s
user 0m31.498s
sys 0m18.899s
postpatch:
real 1m11.465s
user 0m26.382s
sys 0m12.986s
Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
Diffstat (limited to 'submitting-patches')
0 files changed, 0 insertions, 0 deletions