summaryrefslogtreecommitdiff
path: root/lib/libalpm/add.c
diff options
context:
space:
mode:
authorNagy Gabor <ngaba@bibl.u-szeged.hu>2008-03-10 15:38:08 +0100
committerDan McGee <dan@archlinux.org>2008-03-10 18:57:36 -0500
commitd060e31be3586ce27382f80eaed7a9edf2c86aeb (patch)
tree2e7ded6300e22445e539a8ea913a9f296e0739eb /lib/libalpm/add.c
parentf56f7ff39102dab754573b0bc40dbceb5a8ec301 (diff)
downloadpacman-d060e31be3586ce27382f80eaed7a9edf2c86aeb.tar.xz
Remove trans->targets
Its implementation was quite broken: * add_loadtarget() might have silently filtered out some targets when replacing an older version. * This was used in sync.c to determine whether a target is implicit or not, which is incorrect behavior. Before this patch we silently removed user confirmed replacements; now we always warn on a replacement. * remove001.py behavior was quite odd in adding same target 5 times to the target list, we can change this behavior to be a failure. Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu> [Xav: changed remove001 pactest accordingly] Signed-off-by: Chantry Xavier <shiningxc@gmail.com> [Dan: rewrote commit message] Signed-off-by: Dan McGee <dan@archlinux.org>
Diffstat (limited to 'lib/libalpm/add.c')
-rw-r--r--lib/libalpm/add.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/libalpm/add.c b/lib/libalpm/add.c
index 6c0a1eae..4d8e1a03 100644
--- a/lib/libalpm/add.c
+++ b/lib/libalpm/add.c
@@ -848,7 +848,7 @@ int _alpm_add_commit(pmtrans_t *trans, pmdb_t *db)
return(0);
}
- pkg_count = alpm_list_count(trans->targets);
+ pkg_count = alpm_list_count(trans->packages);
pkg_current = 1;
/* loop through our package list adding/upgrading one at a time */