diff options
| author | Xavier Chantry <chantry.xavier@gmail.com> | 2011-04-02 15:53:18 +0200 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2011-04-02 12:37:17 -0500 |
| commit | a46183783504e01a505222c47d1f7fccfeec70e9 (patch) | |
| tree | 5b437722c63f94c00e8de71593318d3a622f9c0f | |
| parent | 0e03c0849ddd799f60e6cf11084b8b62828cce89 (diff) | |
| download | pacman-a46183783504e01a505222c47d1f7fccfeec70e9.tar.xz | |
dload: dont forget to initialize open_mode
That's a funny one, building with optimization levels (with both gcc and
clang) caused open_mode to always be set to "ab", which worked.
This was spotted both with clang-analyzer, and by Jakob who reported a
segfault as he was using an un-optimized build.
Signed-off-by: Xavier Chantry <chantry.xavier@gmail.com>
Signed-off-by: Dan McGee <dan@archlinux.org>
| -rw-r--r-- | lib/libalpm/dload.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/libalpm/dload.c b/lib/libalpm/dload.c index d9e9488a..4ebc868b 100644 --- a/lib/libalpm/dload.c +++ b/lib/libalpm/dload.c @@ -159,7 +159,8 @@ static int curl_download_internal(const char *url, const char *localpath, { int ret = -1; FILE *localf = NULL; - const char *open_mode, *useragent; + const char *useragent; + const char *open_mode = "wb"; char *destfile, *tempfile; char hostname[256]; /* RFC1123 states applications should support this length */ struct stat st; |