summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAllan McRae <allan@archlinux.org>2017-01-04 15:24:23 +1000
committerAllan McRae <allan@archlinux.org>2017-01-04 15:24:23 +1000
commit008fe7b24fded17e4a1a235885057263a3dc413a (patch)
tree5dbf314fb035a00374192c1ba817c6faf64def2d
parent9ad7cda9d8847b6e664f603d6f6c10a7c4fc45a8 (diff)
downloadpacman-008fe7b24fded17e4a1a235885057263a3dc413a.tar.xz
Fix memory leak in alpm_pkg_checkmd5sum
Also remove redundant additional return path. Signed-off-by: Allan McRae <allan@archlinux.org>
-rw-r--r--lib/libalpm/package.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/libalpm/package.c b/lib/libalpm/package.c
index d0f902f0..e9ecc178 100644
--- a/lib/libalpm/package.c
+++ b/lib/libalpm/package.c
@@ -69,9 +69,9 @@ int SYMEXPORT alpm_pkg_checkmd5sum(alpm_pkg_t *pkg)
retval = _alpm_test_checksum(fpath, pkg->md5sum, ALPM_PKG_VALIDATION_MD5SUM);
- if(retval == 0) {
- return 0;
- } else if(retval == 1) {
+ FREE(fpath);
+
+ if(retval == 1) {
pkg->handle->pm_errno = ALPM_ERR_PKG_INVALID;
retval = -1;
}