From 360f88b206f543c648ec5e69b6e3b010cf2e19f3 Mon Sep 17 00:00:00 2001
From: Erich Eckner <git@eckner.net>
Date: Thu, 20 Jun 2019 08:31:06 +0200
Subject: bin/build-packages: add TODO

---
 bin/build-packages | 5 +++++
 1 file changed, 5 insertions(+)

(limited to 'bin/build-packages')

diff --git a/bin/build-packages b/bin/build-packages
index bb2ecba..28a82eb 100755
--- a/bin/build-packages
+++ b/bin/build-packages
@@ -18,6 +18,11 @@
 # TODO: it might be worth trying to build with makedepends installed from
 # [testing] and only depends installed from [staging]
 
+# TODO: the following things need proper locking and/or proper handling of
+# external locks:
+# - `git` on the package source
+# - `archbuild` (e.g. /var/lib/archbuilds/staging-i686-build/root.lock)
+
 # shellcheck disable=SC2016
 usage() {
   >&2 echo ''
-- 
cgit v1.2.3-54-g00ecf


From 6c4aa29866f5af35f03aaa91624d26b9791c85fc Mon Sep 17 00:00:00 2001
From: Erich Eckner <git@eckner.net>
Date: Thu, 20 Jun 2019 08:34:14 +0200
Subject: bin/build-packages: expand TODO

---
 bin/build-packages | 1 +
 1 file changed, 1 insertion(+)

(limited to 'bin/build-packages')

diff --git a/bin/build-packages b/bin/build-packages
index 28a82eb..19c7afe 100755
--- a/bin/build-packages
+++ b/bin/build-packages
@@ -22,6 +22,7 @@
 # external locks:
 # - `git` on the package source
 # - `archbuild` (e.g. /var/lib/archbuilds/staging-i686-build/root.lock)
+# - `find ... -exec umount` on the build chroot
 
 # shellcheck disable=SC2016
 usage() {
-- 
cgit v1.2.3-54-g00ecf


From fcbd37869479e18c38a1ce042b4ae5061b00bb85 Mon Sep 17 00:00:00 2001
From: Erich Eckner <git@eckner.net>
Date: Thu, 20 Jun 2019 08:38:33 +0200
Subject: bin/build-packages: add TODO

---
 bin/build-packages | 3 +++
 1 file changed, 3 insertions(+)

(limited to 'bin/build-packages')

diff --git a/bin/build-packages b/bin/build-packages
index 19c7afe..07e426f 100755
--- a/bin/build-packages
+++ b/bin/build-packages
@@ -24,6 +24,9 @@
 # - `archbuild` (e.g. /var/lib/archbuilds/staging-i686-build/root.lock)
 # - `find ... -exec umount` on the build chroot
 
+# TODO: releave some locking conditions - meta goal: be able to run multiple
+# build slaves on one host from within one archlinux32/builder repository
+
 # shellcheck disable=SC2016
 usage() {
   >&2 echo ''
-- 
cgit v1.2.3-54-g00ecf


From 10a00d63f599aae012314a578cbe9a3edc9e1fd3 Mon Sep 17 00:00:00 2001
From: Erich Eckner <git@eckner.net>
Date: Thu, 20 Jun 2019 08:42:23 +0200
Subject: bin/build-packages: remove code which got moved into archbuild (for
 devtools32)

---
 bin/build-packages | 8 --------
 1 file changed, 8 deletions(-)

(limited to 'bin/build-packages')

diff --git a/bin/build-packages b/bin/build-packages
index 07e426f..3faa77e 100755
--- a/bin/build-packages
+++ b/bin/build-packages
@@ -542,14 +542,6 @@ while [ "${count}" -ne 0 ] && \
         find . -maxdepth 1 -type f \( -name '*.pkg.tar.xz' -o -name '*.pkg.tar.xz.sig' \) -exec \
           rm {} \;
 
-        if echo "${outerParameters}" | \
-          grep -qwF -- '-c'; then
-          # sometimes it is necessary to manually remove the root/ build
-          # directory (due to leftover mounts of /run) - so we just do
-          # it everytime '-c' is set
-          recursively_umount_and_rm '/var/lib/archbuild/'"${build_command%-build}"
-        fi
-
         echo 'building' > "${tmp_dir}/.ping-build-master"
         >&2 printf '%s: building package "%s" (revisions %s %s, repository %s, straw %s) for %s ...' \
           "$(date +'%Y-%m-%d %T')" \
-- 
cgit v1.2.3-54-g00ecf