From fc41ad4920b552ba5e39be169d4b27b5897c7852 Mon Sep 17 00:00:00 2001 From: Erich Eckner Date: Thu, 17 Oct 2019 09:22:44 +0200 Subject: add TODOs for removing hard-coded package suffixes --- bin/build-packages | 2 ++ bin/clean-cache | 2 ++ bin/copy-to-build-support | 2 ++ bin/create-build-support-package | 2 ++ bin/filter-build-logs | 2 ++ bin/interpret-mail | 2 ++ bin/local-build-package | 2 ++ bin/put-upstream-packages-into-db | 2 ++ bin/return-assignment | 2 ++ bin/sanity-check | 2 ++ bin/seed-build-list | 2 ++ lib/common-functions | 2 ++ lib/mysql-functions | 2 ++ 13 files changed, 26 insertions(+) diff --git a/bin/build-packages b/bin/build-packages index 98d013c..ec26366 100755 --- a/bin/build-packages +++ b/bin/build-packages @@ -27,6 +27,8 @@ # TODO: releave some locking conditions - meta goal: be able to run multiple # build slaves on one host from within one archlinux32/builder repository +# TODO: remove hard-coded package suffixes + # shellcheck disable=SC2016 usage() { >&2 echo '' diff --git a/bin/clean-cache b/bin/clean-cache index b83e30f..41d0df8 100755 --- a/bin/clean-cache +++ b/bin/clean-cache @@ -5,6 +5,8 @@ # shellcheck source=../lib/load-configuration . "${0%/*}/../lib/load-configuration" +# TODO: remove hard-coded package suffixes + if [ $# -eq 0 ]; then dummynator='sudo' elif [ $# -eq 1 ] && [ "x$1" = 'x-n' ]; then diff --git a/bin/copy-to-build-support b/bin/copy-to-build-support index c1d5cfb..abf11cb 100755 --- a/bin/copy-to-build-support +++ b/bin/copy-to-build-support @@ -9,6 +9,8 @@ # TODO: allow to introduce a manually built package into build-support +# TODO: remove hard-coded package suffixes + # shellcheck disable=SC2016 usage() { >&2 echo '' diff --git a/bin/create-build-support-package b/bin/create-build-support-package index 8998cfb..1d4ec66 100755 --- a/bin/create-build-support-package +++ b/bin/create-build-support-package @@ -3,6 +3,8 @@ # shellcheck source=../lib/load-configuration . "${0%/*}/../lib/load-configuration" +# TODO: remove hard-coded package suffixes + # shellcheck disable=SC2016 usage() { >&2 echo 'usage:' diff --git a/bin/filter-build-logs b/bin/filter-build-logs index 9671376..0a2cbe3 100755 --- a/bin/filter-build-logs +++ b/bin/filter-build-logs @@ -7,6 +7,8 @@ # shellcheck source=../lib/load-configuration . "${0%/*}/../lib/load-configuration" +# TODO: remove hard-coded package suffixes + { printf '%s\n' \ '' \ diff --git a/bin/interpret-mail b/bin/interpret-mail index 0532688..ee218e7 100755 --- a/bin/interpret-mail +++ b/bin/interpret-mail @@ -5,6 +5,8 @@ # shellcheck source=../lib/load-configuration . "${0%/*}/../lib/load-configuration" +# TODO: remove hard-coded package suffixes + # shellcheck disable=SC2016 if [ $# -ne 0 ]; then >&2 echo '' diff --git a/bin/local-build-package b/bin/local-build-package index 89b6f77..a80207b 100755 --- a/bin/local-build-package +++ b/bin/local-build-package @@ -7,6 +7,8 @@ # shellcheck source=../lib/load-configuration . "${0%/*}/../lib/load-configuration" +# TODO: remove hard-coded package suffixes + # shellcheck disable=SC2016 usage() { >&2 echo '' diff --git a/bin/put-upstream-packages-into-db b/bin/put-upstream-packages-into-db index 0989b8c..219e146 100755 --- a/bin/put-upstream-packages-into-db +++ b/bin/put-upstream-packages-into-db @@ -3,6 +3,8 @@ # shellcheck source=../lib/load-configuration . "${0%/*}/../lib/load-configuration" +# TODO: remove hard-coded package suffixes + upstream_packages=$(mktemp "${work_dir}/tmp.put-upstream-packages-into-db.XXXXXXXXXX") trap 'rm "${upstream_packages}"' EXIT diff --git a/bin/return-assignment b/bin/return-assignment index 0d40123..c8c6ecf 100755 --- a/bin/return-assignment +++ b/bin/return-assignment @@ -19,6 +19,8 @@ # TODO: sign database +# TODO: remove hard-coded package suffixes + # shellcheck disable=SC2119,SC2120 # shellcheck source=../lib/load-configuration diff --git a/bin/sanity-check b/bin/sanity-check index 7014129..75a4206 100755 --- a/bin/sanity-check +++ b/bin/sanity-check @@ -7,6 +7,8 @@ # shellcheck source=../lib/load-configuration . "${0%/*}/../lib/load-configuration" +# TODO: remove hard-coded package suffixes + usage() { >&2 echo '' >&2 echo 'sanity-check [options] [checks]: check sanity of build master' diff --git a/bin/seed-build-list b/bin/seed-build-list index 471ba59..4a8f9b5 100755 --- a/bin/seed-build-list +++ b/bin/seed-build-list @@ -18,6 +18,8 @@ # TODO: allow to reschedule filtered by architecture +# TODO: remove hard-coded package suffixes + # shellcheck disable=SC2016 usage() { >&2 echo '' diff --git a/lib/common-functions b/lib/common-functions index b16e4d7..30b80a2 100755 --- a/lib/common-functions +++ b/lib/common-functions @@ -9,6 +9,8 @@ if [ -z "${base_dir}" ]; then . '../lib/load-configuration' fi +# TODO: remove hard-coded package suffixes + # find_pkgbuilds package repository git_repository git_revision mod_git_revision # find the PKGBUILD and modification of $package from $repository # sets $PKGBUILD and $PKGBUILD_mod diff --git a/lib/mysql-functions b/lib/mysql-functions index 2b09f6b..023de74 100755 --- a/lib/mysql-functions +++ b/lib/mysql-functions @@ -4,6 +4,8 @@ # shellcheck disable=SC2016,SC2039,SC2119,SC2120 +# TODO: remove hard-coded package suffixes + if [ -z "${base_dir}" ]; then # just to make shellcheck happy . '../lib/load-configuration' -- cgit v1.2.3-54-g00ecf