summaryrefslogtreecommitdiff
path: root/bin
diff options
context:
space:
mode:
authorErich Eckner <git@eckner.net>2017-09-19 09:29:46 +0200
committerErich Eckner <git@eckner.net>2017-09-19 09:29:46 +0200
commit93274f3c2ccd1b346354e3ea993e368f8a22298d (patch)
treeb881c38486c1e633cd6d7402640015d126157614 /bin
parent44410e62fe988939136222165da474bcf2d44191 (diff)
downloadbuilder-93274f3c2ccd1b346354e3ea993e368f8a22298d.tar.xz
clean up todos
Diffstat (limited to 'bin')
-rwxr-xr-xbin/common-functions2
-rwxr-xr-xbin/db-update17
-rwxr-xr-xbin/get-assignment8
-rwxr-xr-xbin/get-package-updates14
-rwxr-xr-xbin/return-assignment4
5 files changed, 17 insertions, 28 deletions
diff --git a/bin/common-functions b/bin/common-functions
index dd3b772..c9e516b 100755
--- a/bin/common-functions
+++ b/bin/common-functions
@@ -408,7 +408,7 @@ ls_master_mirror() {
# in all repositories not-older (newer) than $repository
# TODO: implement b) and c)
-
+#
# A package is considered older (not newer) if
# a) its version is older (not newer) or
# b) if its architecture is 'any' and different or
diff --git a/bin/db-update b/bin/db-update
index 427956a..46a4d24 100755
--- a/bin/db-update
+++ b/bin/db-update
@@ -8,20 +8,15 @@
# a) nothing on the build-list run-depends on A and
# b) no done package B which is not being moved run-depends on A
-# TODO:
+# TODO: correctly handle if multiple versions of a single package are marked
+# as "done" or "testing"
-# the meta data used to evaluate condition "b" might be for a different
-# version
+# TODO: be (even?) more atomic
-# correctly handle if multiple versions of a single package are marked
-# as "done" or "testing"
+# TODO: separate locks for staging, testing (and stable)
-# be (even?) more atomic
-
-# separate locks for staging, testing (and stable)
-
-# correctly handle if a package moved from community to official or
-# vice versa
+# TODO: correctly handle if a package moved from community to official or
+# vice versa (delete residues)
# shellcheck disable=SC2039
# shellcheck source=conf/default.conf
diff --git a/bin/get-assignment b/bin/get-assignment
index 2aae1d9..97bdb7b 100755
--- a/bin/get-assignment
+++ b/bin/get-assignment
@@ -11,11 +11,9 @@
# 3: come back after the next run of get-package-updates - currently
# there are no pending packages
-# TODO:
-
-# if all loops are locked, broken packages are not handed out as long
-# as the script believes there is a looped package before the broken
-# one on the build-list - clean up that mess!
+# TODO: if all loops are locked, broken packages are not handed out as
+# long as the script believes there is a looped package before the
+# broken one on the build-list - clean up that mess!
# shellcheck source=conf/default.conf
. "${0%/*}/../conf/default.conf"
diff --git a/bin/get-package-updates b/bin/get-package-updates
index 7d9248a..6bddbea 100755
--- a/bin/get-package-updates
+++ b/bin/get-package-updates
@@ -4,13 +4,12 @@
# Details:
# https://github.com/archlinux32/builder/wiki/Build-system#get-package-updates
-# TODOs:
+# TODO: be more secure in case of update while build(s) is/are still in
+# progress -> (stale) lock files, moving (or changing content of) loop
+# lock files
-# be more secure in case of update while build(s) is/are still in progress
-# -> (stale) lock files, moving (or changing content of) loop lock files
-
-# (might be connected to above): find out who deletes loop-files which
-# should not be deleted
+# TODO: (might be connected to above): find out who deletes loop-files which
+# should not be deleted
# remove extra whitelist cases
@@ -87,8 +86,7 @@ delete_package() {
for repo in ${repo_names}; do
eval repo_path='"${repo_paths__'"${repo}"'}"'
- # TODO:
- # this is somewhat redundant and slow -- improve it!
+ # TODO: this is somewhat redundant and slow -- improve git performance!
git -C "${repo_path}" checkout -f master
git -C "${repo_path}" clean -xdf
git -C "${repo_path}" fetch
diff --git a/bin/return-assignment b/bin/return-assignment
index 4cb8859..e563e31 100755
--- a/bin/return-assignment
+++ b/bin/return-assignment
@@ -14,9 +14,7 @@
# 3: signature error
# 4: package error (e.g. wrong packages sent)
-# TODO:
-
-# fix signing of database
+# TODO: sign database
# shellcheck source=conf/default.conf
. "${0%/*}/../conf/default.conf"